Pete Finnigan's Oracle Security Forum - SQL Injection Question

Forum

Home/Forum

Welcome, Guest. Please Login. Apr 20^th, 2024, 4:34pm News: Welcome to Pete Finnigan's Oracle security forum
Home \| Help \| Search \| Members \| Login

   Pete Finnigan's Oracle Security Forum
   Oracle Security
   Oracle Security (Moderator: Pete Finnigan)
   SQL Injection Question

« Previous topic | Next topic »

Pages: 1

Reply | Notify of replies | Send Topic | Print

Author

Topic: SQL Injection Question (Read 2431 times)

Pete Finnigan
PeteFinnigan.com Administrator

Oracle Security is easier if you design for it

View Profile | WWW | Email

Gender: male

Posts: 309

SQL Injection Question
« on: Apr 8^th, 2008, 12:37pm »

Quote | Modify

Hi,

Is this code secure from SQL injection? If not, how would I exploit it and what would be a better (more secure) way of coding it?

Thanks

Code:

...
FOR row IN (
SELECT EMPNO, ENAME
FROM SCOTT.DEPT
WHERE ENAME LIKE '%'||pName||'%'
) LOOP
...

IP Logged

Pete Finnigan (email:pete@petefinnigan.com)
Oracle Security Web site: http://www.petefinnigan.com
Forum: http://www.petefinnigan.com/forum/yabb/YaBB.cgi
Oracle security blog: http://www.petefinnigan.com/weblog/entries/index.html

Pete Finnigan
PeteFinnigan.com Administrator

Oracle Security is easier if you design for it

View Profile | WWW | Email

Gender: male

Posts: 309

Re: SQL Injection Question
« Reply #1 on: Apr 10^th, 2008, 12:37am »

Quote | Modify

Assuming pName is a character variable there is no injection vulnerability here as the expression is a simple concatenation of literal values and variable value. There's no opportunity for any unexpected code to be executed.
I'd guess that the p prefix signifies a parameter. If so, I might look at either assigning it to a local variable with a defined length or at least validating its length. If it was an insert or update, I'd definately do some validation on the input value (length, non-printing characters etc).
For a LIKE check, you may (depending on requirements) check whether the parameter string already contains wildcard characters. If the end user isn't supposed to supply wildcards, then "instr(ename,pName) > 0 " may be a better filter.

Finally, if "eName" is a valid column name, I'd be concerned about allowing a variable called pName. If a column "pName" was added to the table, then the SQL would compare the two column values, not one column value against the value of the PL/SQL variable and so have unexpected side-effects.
It is best to have strict naming standards so that variable names and column names are easily distinguishable.

IP Logged

Pete Finnigan
PeteFinnigan.com Administrator

Oracle Security is easier if you design for it

View Profile | WWW | Email

Gender: male

Posts: 309

Re: SQL Injection Question
« Reply #2 on: Apr 10^th, 2008, 3:15pm »

Quote | Modify

Hi,

If the input for pNAME is : '' --
the that would be resolved to: '%' ||'' --||'%'
So all the content of the table will be displayed.
Some other thing to try would be try to call a function like utl_http maybe?

regards,

Ivan

IP Logged

Pete Finnigan
PeteFinnigan.com Administrator

Oracle Security is easier if you design for it

View Profile | WWW | Email

Gender: male

Posts: 309

Re: SQL Injection Question
« Reply #3 on: Apr 10^th, 2008, 3:43pm »

Quote | Modify

Hi Guys,

Thank you both for your responses.

Gamyers...
You are indeed correct in assuming that the p indicates a parameter, we're checking that we've copied the all the values into local variables now. And we are usually pretty careful with our column names (certainly more-so than SCOTT)

Isaez...
I still can't reproduce a succesful attack using your string...:

Code:

--
-- Prove that the code works
--
SCOTT @ test >
SCOTT @ test > SET SERVEROUTPUT ON
SCOTT @ test >
SCOTT @ test > accept Name prompt "name "
name R
SCOTT @ test > DECLARE
2 lName VARCHAR2(20) := '&Name';
3 BEGIN
4 DBMS_OUTPUT.PUT_LINE('lName: '||lName);
5
6 FOR user IN (SELECT ENAME, SAL
7 FROM EMP
8 WHERE ENAME LIKE '%'||lName||'%') LOOP
9 DBMS_OUTPUT.PUT_LINE(user.ename||', '||user.sal);
10 END LOOP;
11 END;
12 /
old 2: lName VARCHAR2(20) := '&Name';
new 2: lName VARCHAR2(20) := 'R';
lName: R
WARD, 1250
MARTIN, 1250
CLARK, 2450
TURNER, 1500
FORD, 3000
MILLER, 1300

PL/SQL procedure successfully completed.

--
-- Now try SQL injection
--
SCOTT @ test > SET SERVEROUTPUT ON
SCOTT @ test >
SCOTT @ test > accept Name prompt "name "
name '''' --
SCOTT @ test > DECLARE
2 lName VARCHAR2(20) := '&Name';
3 BEGIN
4 DBMS_OUTPUT.PUT_LINE('lName: '||lName);
5
6 FOR user IN (SELECT ENAME, SAL
7 FROM EMP
8 WHERE ENAME LIKE '%'||lName||'%') LOOP
9 DBMS_OUTPUT.PUT_LINE(user.ename||', '||user.sal);
10 END LOOP;
11 END;
12 /
old 2: lName VARCHAR2(20) := '&Name';
new 2: lName VARCHAR2(20) := ''''' --';
lName: '' --

PL/SQL procedure successfully completed.

.... is it possible that you are mistaken? Or are you able to craft an exploit string for the code above?

IP Logged

Pete Finnigan
PeteFinnigan.com Administrator

Oracle Security is easier if you design for it

View Profile | WWW | Email

Gender: male

Posts: 309

Re: SQL Injection Question
« Reply #4 on: Apr 10^th, 2008, 6:16pm »

Quote | Modify

RT,

You are right ''-- as input doesn't work but if you give an empty string then all data will be shown. Search in google for: oracel sql injection "like clause" and you will see possible attacks.
Also take a look at bind variables!

regards,

Ivan

IP Logged

Pages: 1

Reply | Notify of replies | Send Topic | Print


« Previous topic \| Next topic »

PFCLScan
Simply connect PFCLScan to your Oracle database and it will automatically discover the security issues that could make your Oracle database vulnerable to attack and to the potential loss of your data.

Learn more
PFCLObfuscate
PFCLObfuscate is the only tool available that can automatically add license controls to your PL/SQL code. PFCLObfuscate protects your Intellectual Property invested in your PL/SQL database code.

Learn more
PFCLCode
PFCLCode is a tool to allow you to analyse your PL/SQL code for many different types of security issues. PFCLCode gives you a detailed review and reports and includes a powerful colour syntax highlighting code editor

Learn more
PFCLForensics
PFCLForensics is the only tool available to allow you to do a detailed live response of a breached Oracle database and to then go on and do a detailed forensic analysis of the data gathered.

Learn more
PFCLReselling
PeteFinnigan.com Limited has partnered with a small number of relevant companies to resell their products where they enhance or compliment what we do

Learn more
PFCLATK
PFCLATK is a toolkit that allows detailed pre-defined policy driven audit trails for your Oracle database. The toolkit also provides for a centralised audit trail and centralised activity reporting

Learn more
PFCLCookie
PFCLCookie is a useful tool to use to audit your websites for tracking cookies. Scan websites in a natural way using powerful browser driven scanner

Learn more
PFCLTraining
PFCLTraining is a set of expert training classes for you, aimed at teaching how to audit your own Oracle database, design audit trails, secure code in PL/SQL and secure and lock down your Oracle database.

Learn more
PFCLServices
Choose PFCLServices to add PeteFinnigan.com Ltd to your team for your Oracle Security needs. We are experts in performing detailed security audits, data security design work and policy creation

Learn more
PFCLConsulting
Choose PFCLConsulting to ask PeteFinnigan.com Limited to set up and use our products on your behalf

Learn more
PFCLCustom
All of our software products can be customised at a number of levels. Choose this to see how our products can be part of your products and services

Learn more
PFCLCloud
Private cloud, public cloud, hybrid cloud or no cloud. Learn how all of our services, trainings and products will work in the cloud

Learn more
PFCLUserRights
PFCLUserRights allows you to create a very detailed view of database users rights. The focus of the reports is to allow you to decide what privileges and accounts to keep and which to remove.

Learn more
PFCLSTK
PFCLSTK is a toolkit application that allows you to provide database security easily to an existing database. PFCLSTK is a policy driven toolkit of PL/SQL that creates your security

Learn more
PFCLSFTK
PFCLSFTK is a toolkit that solves the problem of securing third party applications written in PL/SQL. It does this by creating a thin layer between the application and database and this traps SQL Injection attempts. This is a static firewall.

Learn more
PFCLSEO
PFCLSEO is a web scanner based on the PFCLScan technology so that a user can easily scan a website for technical SEO issues

Learn more